Add fake for GIDAuthorizationFlowProcessor#287
Open
Alex-4-Git wants to merge 16 commits intorefactorGSIfrom
Open
Add fake for GIDAuthorizationFlowProcessor#287Alex-4-Git wants to merge 16 commits intorefactorGSIfrom
Alex-4-Git wants to merge 16 commits intorefactorGSIfrom
Conversation
Alex-4-Git
force-pushed
the
pin-GIDAuthorizationFlowProcessor-fake
branch
from
687bbd8 to
2d60ea9
Compare
Alex-4-Git
requested review from
mdmathias and
petea
and removed request for
mdmathias
Alex-4-Git
force-pushed
the
pin-GIDAuthorizationFlowProcessor-fake
branch
from
c54f930 to
89649b1
Compare
petea
reviewed
Jan 19, 2023
mdmathias
requested changes
Jan 19, 2023
...rces/GIDAuthorizationFlowProcessor/Implementations/Fakes/GIDFakeAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
...rces/GIDAuthorizationFlowProcessor/Implementations/Fakes/GIDFakeAuthorizationFlowProcessor.m
Show resolved
Hide resolved
Alex-4-Git
force-pushed
the
pin-GIDAuthorizationFlowProcessor-fake
branch
from
620ceff to
df7f780
Compare
henryhl22321
requested review from
henryhl22321
and removed request for
henryhl22321 and
petea
The UI automation test previously used 'go' but it appears the button has been renamed to 'return'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GIDFakeAuthorizationFlowProcessorconforming to the protocolGIDAuthorizationFlowProcessorand use it to replace mock in GIDSignInTest.testNotHandleWrongSchemebecause it is testing the AppAuth API.